This repository was archived by the owner on Oct 27, 2022. It is now read-only.
add getting contact by field #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failing because pep8 is failing on things that this PR didn't touch. Looking into it... |
|
Seems a newer version of pep8 that checks for more things. Updated locally and it showed the same pep8 errors. pep8 errors are now fixed. |
|
Ready for a first review. |
go_http/contacts.py
Outdated
There was a problem hiding this comment.
I wondering whether we shouldn't overload .get_contact() and do something like .get_contact(*args, **kw) and then:
if not kw and len(args) == 1:
return self._contact_by_key(args[0])
elif len(kw) == 1 and not args:
field, value = kw.items()[0]
return self._contact_by_field(field, value)
raise ValueError(".contact() may either be called as .get_contact(contact_key) or .get_contact(field=value)")
Thoughts?
There was a problem hiding this comment.
That seems good, I'll implement that.
|
Left one suggestion and some minor comments. Looks good though. |
|
@hodgestar Changes implemented. Ready for another review. |
|
👍 |
rudigiesler
pushed a commit
that referenced
this pull request
Feb 11, 2015
…tact-by-field add getting contact by field
rudigiesler
deleted the
feature/issue-10-add-getting-contact-by-field
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality for getting a contact by a field (eg. MSISDN) is now implemented in the contacts API, we should now implement this functionality in the client.