This repository was archived by the owner on Oct 27, 2022. It is now read-only.
Add support for firing metrics via the new metrics posting route on the metrics API. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review but we should probably decide how praekelt/go-metrics-api#18 will be resolved before landing this. |
…cs-via-metrics-api
…e never valid Python identifiers.
|
Ready for review. |
go_http/metrics.py
Outdated
|
Just the one comment from me |
|
Ready for re-review. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vumi Go metrics API gained support for firing metrics in praekelt/go-metrics-api#16. We need to add support for calling that to the metrics client.