Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Use grid layout for dashboard #9

Merged
merged 9 commits into from
Jun 13, 2014
Merged

Use grid layout for dashboard #9

merged 9 commits into from
Jun 13, 2014

Conversation

justinvdm
Copy link
Contributor

No description provided.

@justinvdm justinvdm self-assigned this Jun 9, 2014
@justinvdm
Copy link
Contributor Author

Ready for review.

Some of the accessors actually have a this context which isn't what it usually is (the respective DOM element), but that's also the case for less related things already in the docs, planning on doing it in a separate PR: #10.

hodgestar
hodgestar reviewed Jun 13, 2014
View reviewed changes
docs/api/dashboard.rst
``undefined``, the dashboard will fall back to the relevant widget type's
``colspan`` property.

The default accessor tries look up the ``colspan`` property of each datum.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tries to

@hodgestar
Copy link
Contributor

Other than the doc suggestions, looks good!

@justinvdm
Copy link
Contributor Author

Thanks for reviewing this late on a Friday :) ready for re-review.

@hodgestar
Copy link
Contributor

👍

@justinvdm justinvdm merged commit 89d309c into develop Jun 13, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@justinvdm justinvdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinvdm @hodgestar