Concurrency In Elixir Homework: Name:Ethan Potthoff ID:47353076 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragdave
reviewed
Oct 20, 2019
Comment on lines
+80
to
+81
| {:next_is, value} -> | ||
| counter(value) |
There was a problem hiding this comment.
I'm not sure why this is here: it doesn't seem to be invoked from anywhere
-1
pragdave
reviewed
Oct 20, 2019
| end | ||
|
|
||
| def new_counter(initial_value \\ 0) do | ||
| # ... your code | ||
| new_count = spawn Ex01, :counter, [initial_value] |
There was a problem hiding this comment.
There's a warning that new_count is never used. In general, you should clear all warning in code (not just when submitting assignments)
-1
Comment on lines
+54
to
+58
| chunk_val = div(Enum.count(collection),process_count) | ||
| chunks = Enum.chunk_every(collection, chunk_val) | ||
| pids = Enum.map(chunks, fn chunk -> spawn(Ex03, :chunk_process, [chunk, function, self()]) end) | ||
| result_list = Enum.map(pids, fn pid -> (receive do {^pid, value} -> value end) end) | ||
| List.flatten(result_list) |
There was a problem hiding this comment.
This was so close to being a pipeline:
collection
|> Enum.chunk_every(chunk_val)
|> Enum.map(fn chunk -> spawn(Ex03, :chunk_process, [chunk, function, self()]) end)
|> Enum.map(fn pid -> (receive do {^pid, value} -> value end) end)
|> List.flatten()I'm deducting 4 here just because I did ask for one...
-4
No deduction, but you could have used Enum.flat_map and saved having the List.flatten call.
pragdave
reviewed
Oct 21, 2019
| @@ -51,12 +51,17 @@ defmodule Ex03 do | |||
| """ | |||
|
|
|||
| def pmap(collection, process_count, function) do | |||
| # your code goes here | |||
| # I'm hoping to see a simple pipeline as the body of this function... | |||
| chunk_val = div(Enum.count(collection),process_count) | |||
There was a problem hiding this comment.
The div returns the wrong answer: div(10,4) returns 2, which means you'd get 5 processes. It should be
div(Enum.count(collection) + process_count - 1, process_count)
-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.