Nicholas Crothers Submission #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragdave
reviewed
Oct 20, 2019
Comment on lines
+56
to
+61
| range_to_enumerable(collection) | ||
| |> splitmap(process_count) | ||
| |> spawnchunks(function) | ||
| |> receivechunks | ||
| |> flatten_result | ||
| end |
There was a problem hiding this comment.
YES!
Thank you for structuring it like this...
Comment on lines
+63
to
+65
| def range_to_enumerable(range) do | ||
| Enum.map(range, fn x -> x end) | ||
| end |
There was a problem hiding this comment.
Range is already enumerable. In fact, this function makes that assumption, as map wouldn't work otherwise...
|
|
||
| def spawnchunks(chunks, function) do | ||
| me = self() | ||
| Enum.map(chunks, fn chunk -> spawn(fn -> process(chunk, function, me) end) end) |
pragdave
reviewed
Oct 20, 2019
| end | ||
|
|
||
| def splitmap(enumerable, process_count) do | ||
| Enum.chunk_every(enumerable, div(length(enumerable), process_count)) |
There was a problem hiding this comment.
The div here returns the wrong value (try it with 10 and 4).
-2
pragdave
reviewed
Oct 21, 2019
| # « your code goes here» | ||
| # You can give an agent a name by adding the | ||
| # `name: @global_name` option to start_link | ||
| {:ok, pid} = Agent.start_link(fn -> initial_value end, name: @global_name) |
There was a problem hiding this comment.
This line generates a warning because pid is unused.
-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name: Nicholas Crothers
ID: 47330742