Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused variable warnings #453

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Fix unused variable warnings #453

merged 1 commit into from
Nov 2, 2022

Conversation

jcrevits
Copy link
Contributor

@jcrevits jcrevits commented Nov 2, 2022

Hello! I noticed a few warnings when upgrading to the latest version 👇

I'll leave it up to you if you would rather keep the pattern matching but prefix the variables with _. I went for the other option.

Thank you for maintaining this lib! :)

Compiling 15 files (.ex)
warning: variable "fno" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/earmark/options.ex:201: Earmark.Options._check_options!/1

warning: variable "line" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/earmark/options.ex:205: Earmark.Options._check_options!/1

warning: variable "fno" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/earmark/options.ex:209: Earmark.Options._check_options!/1

warning: variable "line" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/earmark/options.ex:209: Earmark.Options._check_options!/1

Generated earmark app

@RobertDober RobertDober merged commit 87a9c49 into pragdave:master Nov 2, 2022
@RobertDober
Copy link
Collaborator

Thank you for doing my job ;) Shoudda have caught this one.

I'll leave it up to you if you would rather keep the pattern matching but prefix the variables with _. I went for the other option.

Perfectly fine what you did!

@RobertDober
Copy link
Collaborator

Je suppose que nous sommes Français/francophone, tous les deux (bien je le sais pour moi ;)) donc Merci Encore

@jcrevits
Copy link
Contributor Author

jcrevits commented Nov 2, 2022

Effectivement ! Un bon nombre de français/francophones maintiennent/trainent dans le monde d'Elixir 😛 De rien et bon courage !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants