gapless playback feature #36
Conversation
…setting of played songs pixbuf in update_pixbuf_state_on_path().
…rmats. Use playbin2s "about-to-finish"-signal to prepare the next track and set it's uri. Once the track change has happened, playbin2 will send a "playbin2-stream-changed" message. Catch the message, update playlist and gui. If for any reason the next track can not be prepared before playbin2 finishes the current track, the EOS (end of stream) signal will trigger the non-gapless playback_advance code. Note: Gapless playback will only work with file formats that do not use padding. FLAC and Ogg Vorbis (and possibly others) will be fine, but mp3 does not work. Nevertheless, even mp3 playback will benefit from these changes as they eliminate any gaps resulting from playback state changes.
| if(cwin->cstate->curr_mobj->file_type == FILE_CDDA || | ||
| cwin->cstate->curr_mobj->file_type == FILE_HTTP) { | ||
| g_object_set(G_OBJECT(cwin->cgst->pipeline), "uri", cwin->cstate->curr_mobj->file, NULL); | ||
| g_free (uri); |
|
Thanks for the comments, I'm working on it. Clearing the progress bar works fine, will post a new commit as soon as I have finished de-uglyfying the rest :) |
- Gapless track change to a stream uri results in previous songs length playing time reported as song length by gstreamer. Upstream bug? For some reason, this persisted in tags->length... For now, make sure the length tag is set to 0 so we don't get progress bar errors. - Improve codin style
… percentual value instead of stream name and a zero time value. Also fixes remaining problem with song length bug showing while buffering.
|
Ohh.. I see you continued developing. ;) |
|
Actually, yes. Changing to a non-existent track in the playlist seems to cause all following tracks to be considered broken by pragha. As this leeds to segfault, I definitely have to fix it. I have stumbled on a quite similar bug in my early experiments on gapless with pragha, but while both are caused by playlist-issues they seem a little different... I also encountered an issue with playbin2 switching to a FLAC file from an mp3. Took some seconds to start playback, played about one second and jumped a few seconds forward, not playing what was in-between... Well, once the gapless code is sorted out I will probably have a look at gstreamers replay gain plugins. |
|
Just a note to remember: I found it when see the port of rhyntombox to gstreamer 1.0. But it seems that does not exist in 0.10.. :S Regards. p.s: Unfortunately there are many changes in the bancked, and this patch is not applicable. Sorry. After solving other problems, maybe I dedicate with this. |
|
No problem - thanks for the note, this might help. I still want to see On 25.10.2012 16:30, matiasdelellis wrote:
|
Conflicts: src/current-playlist.c src/pragha-backend.c src/pragha.h
ghost
mentioned this pull request
Add gapless playback for audio files that natively support it to pragha. Comments welcome ;)