Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Cursor added #94

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

loki1205
Copy link

Related to #77

Describe the changes you've made

< Give_a_clear_description_what_modifications_you_have_made >

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.

@netlify
Copy link

netlify bot commented Apr 22, 2023

Deploy Preview for arito ready!

Name Link
🔨 Latest commit 7b6d313
🔍 Latest deploy log https://app.netlify.com/sites/arito/deploys/6444dc57a8e9c1000862d288
😎 Deploy Preview https://deploy-preview-94--arito.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your First Pull Request! Wish you best on your open-source journey 😊

@prakhartiwari0
Copy link
Owner

This is very cool!

However, there are some locations where this cursor is not working, can you please look into it? @loki1205

@loki1205
Copy link
Author

This is very cool!

However, there are some locations where this cursor is not working, can you please look into it? @loki1205

Can you please share some screenshots or screen recordings of where it is not working? It will be helpful.

@prakhartiwari0
Copy link
Owner

@loki1205 Here's the screen recording of the issue 👇🏼

issue.mp4

Copy link

@its-your-invi its-your-invi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The default cursor size in windows is 32 X 32 but the image of the cursor you added has dimension : 57 X 54. Please resize the image and make it to 32 X 32 or lower than it.

  2. In main.css, the cursor is made somewhere pointer or grab. You have to do changes there. You can add the same image or pointer or grab type images of cursor at that points.

After these changes the issue will be resolved. If you still have any doubt, feel free to ask.

@prakhartiwari0
Copy link
Owner

  1. The default cursor size in windows is 32 X 32 but the image of the cursor you added has dimension : 57 X 54. Please resize the image and make it to 32 X 32 or lower than it.
  2. In main.css, the cursor is made somewhere pointer or grab. You have to do changes there. You can add the same image or pointer or grab type images of cursor at that points.

After these changes the issue will be resolved. If you still have any doubt, feel free to ask.

These are pretty good suggestions! Thanks for sharing them @its-your-invi
Please work on these things @loki1205, and feel free to ask for any kind of help you need :)

Happy Contributing!

@prakhartiwari0
Copy link
Owner

Any updates @loki1205 ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants