Code Review 2 #16
Open
Code Review 2 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Analysis of the program. - The program takes user data and saves it to firebase, I don’t see my profile post data yet. I know we are still trying to grasp it. • Was the program available in UC Github on time? -Yes it was • Is the program documented/commented well enough for you to understand? - Yes, variables are clear on what is going on in the project • Does the program compile? - Yes from unit test and app. • Rationale behind your changes. - It is hard for me to change much as they are very organized. I did noticed that an interface was not in the dao folder. I moved IUniversityService to dao. Ran a test and everything seemed to work. I assumed they are using two JSON streams as if I just use one the program gets errors. • Links to three specific commits that you made to your own group's GitHub repository after Sprint 1's deadline, and before Sprint 2's deadline. • Three technical concepts - Firebase implementation - Implementing buttons to the project\ MainViewModel sending and gaining information from firebase.
discospiff
reviewed
Apr 6, 2022
| import com.example.uniconnect.service.IUniversityService | ||
| import com.example.uniconnect.dao.IUniversityService |
There was a problem hiding this comment.
A service interface belongs in a service package, not a dao package. I'd leave this as it were.
|
There's not enough technical debt reduction in this branch to warrant merging it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Analysis of the program.
• Was the program available in UC Github on time?
-Yes it was
• Is the program documented/commented well enough for you to understand?
• Does the program compile?
• Rationale behind your changes.
• Links to three specific commits that you made to your own group's GitHub repository after Sprint 1's deadline, and before Sprint 2's deadline.
• Three technical concepts
MainViewModel sending and gaining information from firebase.