Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mysql testdb #3

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Add mysql testdb #3

merged 1 commit into from
Aug 3, 2018

Conversation

henrykironde
Copy link

RMySQL has been replaced by RMariaDB
ropensci#149

RMySQL has been replaced by RMariaDB
ropensci#148
@henrykironde
Copy link
Author

@pranita-s the tests look fine now(merge this to see how it runs).
Clean up the travis file and add comments where applicable. You could try installing these packages

  - R -e 'install.packages(c("devtools"));if (!all(c("devtools") %in% installed.packages())) { q(status = 1, save = "no")}'
  - R -e 'install.packages(c("devtools"));if (!all(c("devtools") %in% installed.packages())) { q(status = 1, save = "no")}'
  - R -e 'library(devtools);devtools::install_github("klutometis/roxygen")'
  - R -e 'library(devtools);devtools::install_github("rstats-db/DBI")'
  - R -e 'library(devtools);devtools::install_github("rstats-db/RMariaDB")'
  - R -e 'devtools::install_github("rstudio/reticulate")'

using

r_github_packages:
  - r-lib/devtools
  - klutometis/roxygen
  - rstats-db/DBI
  - rstats-db/RMariaDB
  - rstudio/reticulate

Also try removing the script: section so that R can use the default test procedures.
This is because if we run

- R -e 'library(testthat)'
- R -e 'library(devtools);devtools::test()'

The tests do not show failures.
ref :r-lib/testthat#700

@pranita-s pranita-s merged commit 50a4358 into pranita-s:Testing Aug 3, 2018
@henrykironde henrykironde deleted the tests branch December 19, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants