-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MVP Nixos patches #1152
MVP Nixos patches #1152
Conversation
@@ -18,6 +18,11 @@ do | |||
tgt=`echo $lst | awk -F '|' '{print $2}'` | |||
tgt=`eval "echo $tgt"` | |||
|
|||
if [[ "${tgt}" =~ /usr/share/ && -d /run/current-system/sw/share/ ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kik4444 Why do you search for that directory precisely instead of just searching anything Nixy, like /nix/store, or even just a uname
? Is that directory precisely of any use in that evaluation?
I say that because if it's as relevant to put /nix/store, then I would like to put /gnu/store detection aswell so the script skips multiple stateless OSes when detecting those
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I just wasn't aware of any others besides NixOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I just wasn't aware of any others besides NixOS.
Nevermind actually you use that share directory as a substitute in the script, hence why you search for it precisely instead of only looking for NixOS in itself
RofiSel=$( for qapp in "$@" | ||
do | ||
Lkp=`grep "$qapp" /usr/share/applications/* | grep 'Exec=' | awk -F ':' '{print $1}' | head -1` | ||
Lkp=`grep "$qapp" $appDir/applications/* | grep 'Exec=' | awk -F ':' '{print $1}' | head -1` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here the $appDir
already points to /usr/share/applications
, so please remove applications
from this line
Lkp=`grep "$qapp" $appDir/* | grep 'Exec=' | awk -F ':' '{print $1}' | head -1`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you!
* Skip extracting things to /usr/share on NixOS * Use /usr/bin/env for spotify * Patch quickapps.sh * Patch themeswitch.sh * Fix app dir in quickapps.sh
Pull Request
Description
I think I will take a break here. With these changes I think I've achieved at least an MVP if you will. I manually deployed Hyprdots as best as I knew. I placed the repo in my home dir, copied all the relevant dirs from
Configs/.config/
to~/.config
, fixed all the symlinks to point to/home/my-user/...
instead of the default/home/tittu/...
, edited theCloneDir
inConfigs/.config/hyprdots/scripts/globalcontrol.sh
. Basically I tried to manually do the jobs ofrestore_fnt.sh, restore_cfg.sh, restore_lnk.sh
.When I rebooted into Hyprland it kinda worked. I had the Catpuccin theme, waybar on the bottom (though the icons and text were too small!), an indicator for the currently active window, working icons for wlogout (though its colors and icons were missing), cliphist, the buttons for changing themes and wallpapers. On the right I had the applets for bluetooth, network manager, any other background apps I had running.
Media keys worked, dunst seemed like it worked (it didn't have any animations when multiple stacked notifications disappeared, though there were animations when only one notification disappeared, and the blue background color seemed a bit ugly so idk if it was intended). The wallpaper and theme changer maybe worked, though I had to click them multiple times, then kvantum manager appeared and when I closed it only then did the wallpaper and theme change with the proper animation.
The keybindings hint menu and rofi also worked.
I'm not sure how close I got to the proper Hyprdots experience, but my completely subjective assessment is that I got 80% of the way there.
From here on I will likely make my own setup based on Hyprdots and maybe rewrite some of the scripts to nushell to get better performance and eliminate the abundance of
awk
andjq
calls. That is, assuming I don't lose interest in Hyprland by then. After all, it takes a lot of effort and will to setup everything myself as someone who hails from KDE Plasma 6.Type of change
Please put an
x
in the boxes that apply:Checklist
Please put an
x
in the boxes that apply: