Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunked file upload #714

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Chunked file upload #714

merged 1 commit into from
Feb 12, 2022

Conversation

mythsmith
Copy link
Contributor

@mythsmith mythsmith commented Feb 6, 2022

Removes any PHP or server-side file-upload limits by using file chunks.

Cheap shared hosting services usually does not allow to change file upload settings, to save resources. By allowing Dropzone chunked file upload feature, unlimited size files can be uploaded.

Removes any PHP or server-side file-upload limits by using file chunks
@prasathmani
Copy link
Owner

I will validate and merge the code

@mythsmith
Copy link
Contributor Author

Thanks @prasathmani . I made the changes in a hurry, and I realize they are very little documented. I can further document them if you wish. Also, the chunked behaviour could be configured as option, and offer further tweaks (chunksize, maximum file upload, etc).

@kofbox
Copy link

kofbox commented Feb 9, 2022

@prasathmani Good day. I would like to add that this option will be extremely useful for everyone who uses CloudFlare services for their sites, even if they use "not cheap hosting", since CloudFlare sets chunk size for the minimum tariff plan "Free" - 100 Mb, and for the maximum tariff plan - 500 Mb.

@prasathmani prasathmani merged commit c3a2f1d into prasathmani:master Feb 12, 2022
michael-milette pushed a commit to michael-milette/moodle-local_tinyfilemanager that referenced this pull request Feb 12, 2022
Removes any PHP or server-side file-upload limits by using file chunks
@ramok
Copy link

ramok commented Apr 20, 2023

        if(file_exists ($fullPath) && !$override_file_name && !$chunks) {

there is only place where variable chunks used
... PHP Notice: Undefined variable: chunks ...tinyfilemanager/tinyfilemanager.php on line 951

@ner00
Copy link
Contributor

ner00 commented Apr 21, 2023

Yes, very strange. I wonder if the variable $chunks was ever used before, as it stands it doesn't serve any purpose.

@ner00
Copy link
Contributor

ner00 commented Apr 21, 2023

This was fixed after issue #1025 and merged PR #1026

ner00 pushed a commit to ner00/tinyfilemanager that referenced this pull request May 7, 2023
Removes any PHP or server-side file-upload limits by using file chunks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants