Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Chinese(Simplified) translation. #33

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Added Chinese(Simplified) translation. #33

merged 1 commit into from
Jan 3, 2022

Conversation

mnipritom
Copy link
Contributor

@prateekmedia Hi. This is my first ever contribution to any Open Source software and I would like to utilize this commit as a conversation starter for issue #16 and present my findings about it. First of all, I can confirm the issue persists on KDE Neon 5.23.4, apart from aforementioned distributions in the issue thread. Here is the console output of the exact exception thrown by Flutter sdk (ignoring the ones regarding SVG) :

[ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: Exception: Couldn't find the executable zenity in the path.
#0      isExecutableOnPath (package:file_picker/src/utils.dart:60:5)
<asynchronous suspension>
#1      FilePickerLinux._getPathToExecutable (package:file_picker/src/file_picker_linux.dart:95:14)
<asynchronous suspension>
#2      FilePickerLinux.getDirectoryPath (package:file_picker/src/file_picker_linux.dart:55:24)
<asynchronous suspension>
#3      PrefsDialog.build.<anonymous closure> (package:appimagepool/widgets/prefs_dialog.dart:121:33)
<asynchronous suspension>

I have tried using the latest version (4.3.0) of file_picker to no success. As the implementation for Linux stayed the same from file_picker-4.2.8/lib/src/file_picker_linux.dart line 91-97

Future<String> _getPathToExecutable() async {
    try {
      return await isExecutableOnPath('qarma');
    } on Exception {
      return await isExecutableOnPath('zenity');
    }
  }

As Null safety is the way going forward with Flutter development, I did not check to see for a workaround with older file_picker versions, although I have found they can provide a possible solution https://stackoverflow.com/questions/66541523/file-picker-plugin-doesnt-return-absolute-path-for-write-file-in-flutter.

Even though qarma (https://github.com/luebking/qarma) is a zenity clone based on Qt, it is not used in KDE Neon, Kdialogs (https://develop.kde.org/deploy/kdialog/#file-selection-dialogs) is used instead. @mijorus from issue thread mentioned Pop!_OS 20.04, which packages zenity https://distrowatch.com/resource/popos/popos-20.04.txt. And I would like to draw your attention to this issue miguelpruivo/flutter_file_picker#903, where this behavior was mentioned. Even though they have concluded it to be a result of using the snap package of VSCode, I can confirm the issue persists in using of the .deb package format of VSCode as well.


To get a better picture of the nuances of this particular situation, I would like to invite you watch this video https://www.youtube.com/watch?v=QmcV3scJKXc, since this piece of software is intended to be used across multitude of Linux distributions, where specifications can range from super minimal installation of Linux utilizing various Window managers to fully feature packed gamer focused distros eg Garuda.

As a novice who took interest in software development, I am asking for directions, resources, documentations anything that can point me towards places where I can learn more about working with code that affect real world products, as depth of my understanding is lacking. Thank you.

@prateekmedia
Copy link
Owner

Do you have the same behavior with Folder Picker in this app?

@prateekmedia prateekmedia merged commit 438b024 into prateekmedia:main Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants