[Issue-76] update samples to new builder API #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eron Wright <eronwright@gmail.com>
|
I opened this PR as a heads-up, but frankly I am still testing the samples so I wouldn't recommend merging yet. |
Signed-off-by: Eron Wright <eronwright@gmail.com>
vijikarthi
reviewed
May 15, 2018
| LOG.info("Succesfully created stream: {}", streamId); | ||
| Stream streamId = getStreamId(); | ||
|
|
||
| try(StreamManager streamManager = StreamManager.create(pravegaConfig.getClientConfig())) { |
There was a problem hiding this comment.
Looks like we are duplicating Utils.createStream() here?
There was a problem hiding this comment.
Yeah, I was unable to reuse Utils here because it is in the flink-examples project and so there's way to use it from the anomaly-detection project. Personally I don't think it important to consolidate it.
|
Happy to report that the anomaly detector is working: |
- set default scope explicitly to work better in Nautilus environment - updated help text of anomaly detector - set stream scale policy to 1 for event time-based apps - fixed program output of Java-based turbine processor Signed-off-by: Eron Wright <eronwright@gmail.com>
|
@vijikarthi I updated each sample to use the following approach to creating the Meanwhile, the default stream name should be unqualified. This approach will work best when a default scope ( |
fpj
pushed a commit
that referenced
this pull request
Jun 23, 2018
- rework samples to use the new builder API of the Flink connector - use `PravegaConfig` to establish a Pravega context (connection info, default scope) - set stream scale policy to 1 for event time-based apps - updated help text of anomaly app Signed-off-by: Eron Wright <eronwright@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Utilsclass to create streams as neededHow to Test