Issue 91: PrestopHook configured for zookeeper cluster always fails #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anisha.kj <anisha.kj@dell.com>
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
=======================================
Coverage 53.38% 53.38%
=======================================
Files 7 7
Lines 1107 1107
=======================================
Hits 591 591
Misses 468 468
Partials 48 48
Continue to review full report at Codecov.
|
Prabhaker24
suggested changes
May 28, 2020
Signed-off-by: anisha.kj <anisha.kj@dell.com>
Prabhaker24
approved these changes
May 28, 2020
|
LGTM |
whitleykeith
pushed a commit
to whitleykeith/zookeeper-operator
that referenced
this pull request
Jun 5, 2020
…ravega#186) * Fixed prestop failure in teardown script Signed-off-by: anisha.kj <anisha.kj@dell.com> * added break in for loop Signed-off-by: anisha.kj <anisha.kj@dell.com>
whitleykeith
pushed a commit
to whitleykeith/zookeeper-operator
that referenced
this pull request
Jun 8, 2020
… fails (pravega#186)" This reverts commit d502a60.
whitleykeith
pushed a commit
to whitleykeith/zookeeper-operator
that referenced
this pull request
Jun 8, 2020
… fails (pravega#186)" This reverts commit d502a60.
whitleykeith
pushed a commit
to whitleykeith/zookeeper-operator
that referenced
this pull request
Jun 8, 2020
…r always fails (pravega#186)"" This reverts commit 0fd66ea.
anishakj
pushed a commit
that referenced
this pull request
Jun 8, 2020
…dards (#184) * prefixing service ports with tcp to comply with istio standards * Revert "Issue 91: PrestopHook configured for zookeeper cluster always fails (#186)" This reverts commit d502a60. * Revert "Revert "Issue 91: PrestopHook configured for zookeeper cluster always fails (#186)"" This reverts commit 0fd66ea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: anisha.kj anisha.kj@dell.com
Change log description
Default Termination grace period was set to 30s, and in tearDown.sh we were waiting for 180s for client connection to terminate. Due to this after grace period is over, kubernetes is sending SIGKILL due to that we were getting
137error code. (https://kubernetes.io/docs/concepts/workloads/pods/pod/#termination-of-pods)Purpose of the change
Fixes #91
What the code does
Increased default termination grace period to 180s. In teardown script, corrected the loop for waiting for client connection. Also installed
psin container, as zookeeper-3.5.5 doesnt have it.How to verify it
Verified the following scenarios