Issue 482: Reevaluating number of client connections dynamically in the teardown script #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he teardown script Signed-off-by: Nishant Gupta <Nishant_Gupta3@dell.com>
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
=======================================
Coverage 85.04% 85.04%
=======================================
Files 12 12
Lines 1605 1605
=======================================
Hits 1365 1365
Misses 155 155
Partials 85 85 Continue to review full report at Codecov.
|
amuraru
pushed a commit
to adobe/zookeeper-operator
that referenced
this pull request
Jun 8, 2022
…he teardown script (pravega#483) Signed-off-by: Nishant Gupta <Nishant_Gupta3@dell.com>
mmoscher
pushed a commit
to mmoscher/zookeeper-operator
that referenced
this pull request
Oct 12, 2022
…he teardown script (pravega#483) Signed-off-by: Nishant Gupta <Nishant_Gupta3@dell.com> Signed-off-by: Marco Moscher <moscher@modell-aachen.de>
cheleb
pushed a commit
to cheleb/zookeeper-operator
that referenced
this pull request
Apr 15, 2023
…he teardown script (pravega#483) Signed-off-by: Nishant Gupta <Nishant_Gupta3@dell.com> Signed-off-by: Marco Moscher <moscher@modell-aachen.de>
This was referenced Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nishant Gupta Nishant_Gupta3@dell.com
Change log description
Currently the CONN_COUNT variable is only evaluated once in the zookeeperTeardown.sh script
As a result, the loop would always take 30 seconds if there were client connections present when the script started to run, and ZK pod would terminate with 137 error code with the default termination grace period set to 30s. Need to make sure CONN_COUNT gets reevaluated every cycle and allows the code to break out of the loop earlier.
Purpose of the change
Fixes #482
What the code does
Moves the CONN_COUNT variable inside the for loop
How to verify it
All e2e should pass