Merge pull request #221 from praw-dev/more_test_cleanup

Test cleanup
praw-dev · Dec 9, 2022 · fc84a89 · fc84a89
2 parents 08f4012 + 0bf0bb8
commit fc84a89
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 20 deletions.
diff --git a/tests/integration/models/reddit/test_subreddit.py b/tests/integration/models/reddit/test_subreddit.py
@@ -794,13 +794,11 @@ async def test_add__subreddit_model(self, reddit):
         subreddit = await reddit.subreddit("all")
         await subreddit.filters.add(await reddit.subreddit("redditdev"))
 
-    # @mock.patch("asyncio.sleep", return_value=None) # FIXME: no longer raises not found; same with praw
-    # async def test_add__non_special(self, reddit):
+    # async def test_add__non_special(self, reddit): # FIXME: no longer raises not found; same with praw
     #     reddit.read_only = False
-    #     with self.use_cassette():
-    #         with pytest.raises(NotFound):
-    #             subreddit = await reddit.subreddit("redditdev")
-    #             await subreddit.filters.add("redditdev")
+    #     with pytest.raises(NotFound):
+    #         subreddit = await reddit.subreddit("redditdev")
+    #         await subreddit.filters.add("redditdev")
 
     async def test_remove(self, reddit):
         reddit.read_only = False
@@ -813,13 +811,11 @@ async def test_remove__subreddit_model(self, reddit):
         subreddit = await reddit.subreddit("mod")
         await subreddit.filters.remove(await reddit.subreddit("redditdev"))
 
-    # @mock.patch("asyncio.sleep", return_value=None) # FIXME: no longer rases not found; same with praw
-    # async def test_remove__non_special(self, reddit):
+    # async def test_remove__non_special(self, reddit):  # FIXME: no longer rases not found; same with praw
     #     reddit.read_only = False
-    #     with self.use_cassette():
-    #         with pytest.raises(NotFound):
-    #             subreddit = await reddit.subreddit("redditdev")
-    #             await subreddit.filters.remove("redditdev")
+    #     with pytest.raises(NotFound):
+    #         subreddit = await reddit.subreddit("redditdev")
+    #         await subreddit.filters.remove("redditdev")
 
 
 class TestSubredditFlair(IntegrationTest):

diff --git a/tests/unit/models/test_util.py b/tests/unit/models/test_util.py
@@ -1,8 +1,5 @@
 """Test asyncpraw.models.util."""
 from collections import namedtuple
-from unittest import mock
-
-import pytest
 
 from asyncpraw.models.util import (
     BoundedSet,
@@ -78,9 +75,7 @@ def test_lru_contains(self):
 
 
 class TestStream(UnitTest):
-    @pytest.mark.asyncio
-    @mock.patch("asyncio.sleep", return_value=None)
-    async def test_stream(self, _):
+    async def test_stream(self):
         Thing = namedtuple("Thing", ["fullname"])
         initial_things = [Thing(n) for n in reversed(range(100))]
         counter = 99

diff --git a/tests/unit/test_reddit.py b/tests/unit/test_reddit.py
@@ -194,8 +194,7 @@ async def test_post_ratelimit__over_threshold__seconds(self, mock_sleep, _, redd
             },
         ],
     )
-    @mock.patch("asyncio.sleep", return_value=None)
-    async def test_post_ratelimit__over_threshold__minutes(self, _, __, reddit):
+    async def test_post_ratelimit__over_threshold__minutes(self, _, reddit):
         with pytest.raises(RedditAPIException) as exception:
             await reddit.post("test")
         assert (