Adding proxy support to praw. #206
Conversation
Sites sections of praw.ini now handle the optional directive 'http_proxy'. Example [reddit.com] http_proxy:127.0.0.1:8000 Available URI are the ones handled by the Requests python module. Proxy authentication would work with: http_proxy:user:password@host:port All tests passing (regular tests as well as python setup.py test -s praw.tests.OAuth2Test
docs/pages/configuration_files.rst
Outdated
There was a problem hiding this comment.
Looks like you've interrupted the log_requests documentation here. Please move it after.
|
Great addition overall. Please just make the necessary changes as indicated in-line. Thanks! |
When I added http_proxy, I destroyed the log_requests configuration explanation in the documentation. Fixed.
As suggested by Bryce Boe, the proxy dict creation for the Requests request is now handled once, on the session creation, instead of being created at each request.
There was a problem hiding this comment.
I think this whitespace is necessary for the list to show properly, though I could be wrong. Please verify.
There was a problem hiding this comment.
Well, I re-generated the html doc and it seems fine
2013/4/6 Bryce Boe notifications@github.com
In docs/pages/configuration_files.rst:
@@ -60,10 +60,10 @@ config file. Each site can overwrite any of these variables.
mappings are created dynamically on site creation and thus isn't consistent
across sites.* log_requests A integer that determines the level of API call logging.
I think this whitespace is necessary for the list to show properly.
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/206/files#r3681420
.
|
This looks pretty cool. Be sure to update |
|
I created a 2.0.15 section and added the feature. Will it work for you ? I 2013/4/6 Henri Godron enjoyaol@gmail.com
|
|
My concern is to get it in the changelog, so people can notice your great addition. Bboe is the maintainer and decides on versinoning. I think the best thing would be to just leave it as it is now and he can decide what version to put it in and update the code accordingly when he squashes the commits. |
|
Merged as c3120f5. Deployed as 2.0.15. Thanks! |
Sites sections of praw.ini now handle the optional directive
'http_proxy'.
Example
[reddit.com]
http_proxy:127.0.0.1:8000
Available URI are the ones handled by the Requests python module.
Proxy authentication would work with:
http_proxy:user:password@host:port
All tests passing with and without proxy (regular tests as well as python setup.py test -s
praw.tests.OAuth2Test