Add discontinuation notice to Multireddit.rename()
#1091
Conversation
|
Considering the endpoint no longer works behind the scenes, I think in this case we should just remove the method (and associated tests, etc). This is what we did with |
|
I agree. Let's just remove it. When the upstream API breaks, it's a bug for PRAW to have broken code, so I would argue it's not a violation of SEMVER to remove a method that's no longer working. |
|
Okay, I’ve removed the method and moved the explanation to the git message. LMK if I need to do anything more. Someone who isn’t me needs to check what travis is complaining about. It should have passed. |
|
Please rebase off of master and then the issues should be resolved. |
|
@Pyprohly ping |
|
I now know of two other discontinued endpoints, and their broken PRAW methods. I think I’m going to add them to this PR and remove them all in one swoop soon. Unless there’s a reason to accelerate merging this low priority patch, please be patient. |
This method no longer works due to a change in the Reddit API. The name in the URL can no longer be altered, but the name as shown on the UI can still be updated via `Multireddit.update()`.
Use `.. versionadded::` sphinx markup Remove `__all__` in models/__init__.py
Pyprohly
force-pushed
the
multireddit-rename
branch
from
e6520d5
to
79d64b1
Compare
|
Scratch that. One was a false alarm. The other I’ve just included in another PR. Merging this now. |
Multireddit.rename()always results in a 400 response now since Reddit’s rebranding of multireddits as “Custom Feeds”. We should at least document the discontinuation if.rename()isn’t to be removed just yet.Renaming a multireddit can still be achieved through
Multireddit.update(), although this is change is only shown on the redesign UI and is not reflected in the URL.References