Expand on and restructure pre_push.py

[PythonCoderAS]

I feel that there is no reason for pre_push.py to not run the unit tests, so I added in a command to run the unit tests.

I also moved around imports and changed the return of the main function to be the int of the opposite of the value of success (True=0 and False=1).

[jarhill0]

I'm just weighing in with my personal opinion, so don't take this as a PR review.

I feel that there is no reason for pre_push.py to not run the unit tests

Could this be optional? Maybe via a command-line option like python3 pre_push.py tests? My reason is that, when I'm developing for PRAW, I usually run tests as I develop them, and once they pass I use pre_push.py for style/docs checks. So in my own use-case, running the tests again would be redundant.

Or, alternatively, could there be an option to do style checks only? Such as python3 pre_push.py style?

[PythonCoderAS]

I'm just weighing in with my personal opinion, so don't take this as a PR review.

I feel that there is no reason for pre_push.py to not run the unit tests

Could this be optional? Maybe via a command-line option like python3 pre_push.py tests? My reason is that, when I'm developing for PRAW, I usually run tests as I develop them, and once they pass I use pre_push.py for style/docs checks. So in my own use-case, running the tests again would be redundant.

Or, alternatively, could there be an option to do style checks only? Such as python3 pre_push.py style?

usage: pre_push.py [-h] [-n] [-u] [-a]

Run static and/or unit-tests

optional arguments:
  -h, --help            show this help message and exit
  -n, --unstatic        Do not run static tests
                        (black/flake8/pydocstyle/sphinx-build)
  -u, --unit-tests, --unit
                        Run the unit tests
  -a, --all             Run all of the tests (static and unit). Overrides the
                        unstatic argument.

This is the solution. I understand having -a is redundant, but if I was new I would expect there to be an all option

[bboe]

A few minor suggestions, otherwise I really like this improvement. Great work!

[bboe]

There needn't be this blank line here. Also argparse should be just before import sys.

[bboe]

Can you use "".format here rather than string concatenation? I'm actually more partial to f-strings now, however, python 3.5 doesn't support them, and it's not EOL until September 2020.

[bboe]

Thanks! 🎆