Add py3.5 compatible stubs to objector.py #1173
Conversation
praw/objector.py
Outdated
| from .exceptions import APIException, ClientException | ||
| from .util import snake_case_keys | ||
| from typing import Dict, List, Any, Union, Optional, NoReturn, TypeVar |
There was a problem hiding this comment.
Can you move system-level imports above package-level ones?
|
Thanks! 🎆 |
| def check_error(cls, data): | ||
| def check_error( | ||
| cls, data: Union[List[Any], Dict[str, Dict[str, str]]] | ||
| ) -> NoReturn: |
There was a problem hiding this comment.
I believe usage of NoReturn here is incorrect. Per the documentation:
Special type indicating that a function never returns.
The check_error function sometimes never returns (when an exception is raised) but usually returns None (when no exception is raised). Type annotations should be updated to reflect this. I'm not familiar with type annotations, but perhaps a Union[NoneType, NoReturn] would be appropriate.
There was a problem hiding this comment.
I decided to just not use NoReturn so this should be phased out as well. I’m on a phone now so I’ll make a PR tomorrow.
There was a problem hiding this comment.
Good catch @jarhill0. To be honest, I haven't really scrutinized these PRs at all. I figure it's all an improvement, even if it's not 100% perfect.
Parent: #1164
Type hints: