Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to load refresh_token from praw.ini #408

Closed
wants to merge 11 commits into from
Closed

Add ability to load refresh_token from praw.ini #408

wants to merge 11 commits into from

Conversation

JKauff
Copy link
Contributor

@JKauff JKauff commented May 8, 2015

I have a bot that does not run 24/7, only uses 1 reddit account, and has no additional configuration. With this change, I can store refresh_token along with client_id and client_secret in praw.ini and simply refresh_access_information() on bot startup to retrieve a new access_key.

@bboe
Copy link
Member

bboe commented May 8, 2015

Looks great. Could you please also update the config file doc to include a description of the parameter?
https://github.com/praw-dev/praw/blob/master/docs/pages/configuration_files.rst

Thanks for the contribution!

JKauff added 9 commits May 8, 2015 10:02
Add parameter description for oauth_refresh_token.
Add parameter description for oauth_refresh_token.
Add parameter description for oauth_refresh_token
Add parameter description for oauth_refresh_token and other OCD fixes.
Add parameter description for oauth_refresh_token and other OCD fixes.
@JKauff
Copy link
Contributor Author

JKauff commented May 8, 2015

Lol oops. Sorry for all of the reverts/commits. I'm new to git. I think it's ready now.

@bboe
Copy link
Member

bboe commented May 9, 2015

Merged as 7ffcb63. Thanks for the contribution.

Tip for your next pull request:

  • it's a bit easier to create a branch other than master for a pull request. That way you can have your local master branch reflect the main master branch, and make changes only to your pull request branch as desired
  • Assuming you do the former git rebase -i master is your friend for cleaning up duplicate commits. In this case, you can just fixup all subsequent commits into the first one.

Congrats on your first PRAW contribution, and thanks again!

@bboe bboe closed this May 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants