Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to the textstyle plugin #867

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

Robby-
Copy link
Contributor

@Robby- Robby- commented Apr 4, 2016

No description provided.

@driftypuddle
Copy link

textstyle space you need that space because if you set color or bold or such and do a emote without take or space the emote does not show

@Robby-
Copy link
Contributor Author

Robby- commented Dec 22, 2016

Oh, this still isn't merged yet? I forgot about this one, we've been using this ourselves since I submitted this here.

And, yes, I can see that emote thing is indeed a problem, but I do not think leaving the space there is the correct solution just to accommodate the emotes. The space really is unnecessary, and makes text appear ugly on IRC as well (everything was prefixed with a space). So in regards to this plugin, removing the space really is the correct fix here.

The emote not appearing because of that should best be fixed another way (though, I don't know how).

@driftypuddle
Copy link

yes I agree I can't remove the space at the mo too many users moaning not sure my self on how to fix the emote as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants