Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Show image is displayed incorrectly #72

Closed
EdyDeveloper opened this issue Jun 30, 2022 · 2 comments
Closed

Bug: Show image is displayed incorrectly #72

EdyDeveloper opened this issue Jun 30, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@EdyDeveloper
Copy link

EdyDeveloper commented Jun 30, 2022

Describe the bug
The primary show image is shown with blurred bars instead of how it was before moving to SASS. (Not all shows but most of them).

To Reproduce
Steps to reproduce the behavior:

  1. Add JellySkin
  2. Click on any library (or look at the latest X category, etc. | Basically look at a show's image)
  3. Inspect the show image

Expected behavior
The show's image should fill the whole rectangle and not have blurred bars anywhere like it was before.

Screenshots

This is how it looks currently (JellySkin 12.0.1):
Latest "X" section
image
Library view / Shows section
image

This is how it looked before:
Latest "X" section
image
Library view / Shows section
image

Desktop (please complete the following information):

  • OS: Microsoft Windows 11 Release 21H2 (Build 22000.739)
  • Browser: Microsoft Edge
  • Version: 103.0.1264.37 64-bit

Smartphone (please complete the following information):

  • Device: Samsung Galaxy Note 20 Ultra 5G (Snapdragon version)
  • OS: Android 12 (One UI 4.1)
  • Browser: Google Chrome
  • Version: 102.0.5005.125

Additional Info

  • I did try incognito, another browser, another computer, and my phone.
  • I think that the problem is the image size. The images that don't have this issue are 400x600. Anything under that seems to have this issue. This doesn't occur with the old non-sass version so I think it definitely can be fixed.
  • My Jellyfin server is hosted on a Windows 10 Pro (Build 19044.1766) computer.
  • I am using Jellyfin 10.7.7 but I have tested Jellyfin 10.8 in a VM and this issue still occurs.

Thanks a lot for this awesome theme. Keep up the good work! (If you think I did something incorrectly please let me know!)

@EdyDeveloper EdyDeveloper added the bug Something isn't working label Jun 30, 2022
@EdyDeveloper EdyDeveloper changed the title Bug: Bug: Show image is displayed incorrectly Jun 30, 2022
@prayag17
Copy link
Owner

prayag17 commented Jul 1, 2022

Yeah the blurred bars are there because I made it in such a way that if the image is smaller than the card the full card image can be seen. Though it is only meant for square cards. I will fix this

prayag17 added a commit that referenced this issue Jul 2, 2022
…ow all library tiles on home screen #70, and more
@prayag17
Copy link
Owner

prayag17 commented Jul 2, 2022

Fixed in version 12.0.2

@prayag17 prayag17 closed this as completed Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants