OpenVR and OpenXR symmetric and other projection matrix options #196
Conversation
… tidying up but appears to work correctly
…Index's almost vertically symmetric projection)
… need to verify OpenXR signs
…ng with no image quality loss (at the expense of performance)
src/mods/vr/runtimes/OpenXR.cpp
Outdated
| this->eyes[i][3] = Vector4f{*(Vector3f*)&pose.position, 1.0f}; | ||
| // if we've not yet derived an eye projection matrix, or we've changed the projection, derive it here | ||
| // Hacky way to check for an uninitialised eye matrix - is there something better, is this necessary? | ||
| if (this->should_recalculate_eye_projections || this->projections[0][2][3] == 0) { |
There was a problem hiding this comment.
You can stop the execution of this entire function if should_recalculate_eye_projections is false, not just this block at the bottom.
After every call to respective runtime's VRRuntime::synchronize_frame(), should_recalculate_eye_projections could get set back to true. Doing this once per frame isn't bad at all, which synchronize_frame essentially signals. Or even once every N frames could work too.
i.e.:
VRRuntime::Error OpenXR::update_matrices(float nearz, float farz) {
if (!this->should_recalculate_eye_projections) {
return VRRuntime::Error::SUCCESS;
}
...
}
VRRuntime::Error OpenXR::synchronize_frame(std::optional<uint32_t> frame_count) {
....
this->should_recalculate_eye_projections = true;
}There was a problem hiding this comment.
Is it worth leaving the guard in so we're not repeating the eye matrix derivation on every tick, and adding another guard that's unset on sync-frame, which skips the entire function?
…mrbelowski/UEVR into open-vr-and-openxr-symmetric-projection
…added original FOV to log messages when deriving eye matrices
|
Just in case keton@eb17662 rebases cleanly on latest UEVR nightlies and has some minor incompatibilities fixed. I've tried to save the attribution but needed to make some changes for it to compile. Feel free to I'd appreciate this getting merged for AC7 community among others. Currently I need latest plugin API from nightlies and symmetric projection this PR provides. |
|
I'm not precious or fussy about this PR - if you want a clean Git history perhaps cherry picking Keton's changes is the simplest solution? Attribution isn't important. Alternatively I'm happy to abandon this PR and raise another for a new branch with a single commit. Given the history, rebasing / squashing the commits in this PR is awkward enough to feel like a bad idea |
Big PR (sorry...)
This adds various projection matrix tweaks to the Compatibility page - horizontallly symmetric, horizontally mirrored, vertically symmetric, vertically matched, and combinations. It also has an option to extend the render target to accommodate the required cropping of the eye images (so the use can set up, say, symmetric projection and choose whether to keep the image quality but sacrifice some performance, or vice-versa). The changes are applied immediately.
This works for OpenVR and OpenXR - I've tested OpenVR and OpenXR implementations with a Valve Index and a Quest3.
Symmetric projection fixes minor eye differences on some surfaces (seems to be more common when the surface is angled near to the z-axis), and some reflection and other shader disparities. The extent of the improvement depends on the game but something like The Forgotten City is noticably more comfortable with symmetric projection (horizontally symmetric has the biggest impact).