Avoid YAML::XS 0.61 in Makefile.PL #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generally I don't do the generated changes until the release, though I suppose technically that means they're out-of-date until the release so those devs not wishing to use Dist::Zilla aren't able to run the tests... That problem has somehow never come up... So, meh, six of one, half-dozen of the other. And yeah, Build.PL should've been dead... |
YAML::XS 0.61 breaks LoadFile(path()) - ingydotnet/yaml-libyaml-pm#38
META.json is the only way to have test_requires work as expected. META.yml stores test_requires values in build_requires, due to META.yml being META 1.4 and META.json being META 2.0 And build_requires must always be satisfied, even under --notest
kentfredric
force-pushed
the
pull-deps-fixes
branch
from
1e8ff5e
to
40068c9
Compare
|
JSON/YAML typo Nuked ... CodeReview for the wind. |
preaction
added a commit
that referenced
this pull request
Feb 23, 2016
Avoid YAML::XS 0.61 in Makefile.PL
|
Excellent. Thanks! |
preaction
added a commit
to preaction/Statocles
that referenced
this pull request
Feb 23, 2016
YAML::XS 0.61 changed the way that references were treated, attempting to use them as IO::File / IO::Glob objects. Since we were passing Path::Tiny objects, we got an error about "Not a GLOB reference" This is now fixed, but if someone has YAML::XS 0.61, they must upgrade to YAML::XS 0.62 Refs preaction/Beam-Wire#58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally there should be some Prereq specification that only causes tools to upgrade to 0.62 if, and only if, 0.61 is installed.
But that's typically hard and confusing.
So the equivalent logic using @ether's
Dist::Zilla::Plugin::DynamicPrereqsis added here.In the second commit I add
[MetaJSON]because its just generally recommended to ship one if you want to be a good CPAN Citizen. ( esp wr/t build_requires vs test_requires )Footnotes:
Build.PLin the source tree, but nothing seems to update that any more, and this patch has no application toBuild.PL, and I would fully encourage settingBuild.PLon fire =)Closes #57