Compose Roles _before_ instantiation so attrs will work in init #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, workflow was: - create instance w/ args - excess args discarded - apply role - compsed instance becomes broken because required args are missing This commit changes the workflow to: - compose "with" and "class" to create a new anonclass "class" - create instance with args This means attributes applied to roles and all other things that happen with roles will work as intended.
|
Excellent, thanks! Cutting a release now, and I'll make sure Statocles depends on the new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've locally been working with this logic applied and it seems to do what I want.
Tests included.