Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to use false values in Value Services #75

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Allow to use false values in Value Services #75

merged 1 commit into from
Jul 8, 2021

Conversation

al-tom-ru
Copy link
Contributor

Added the ability to use empty (false) value in Value Services:

debug:
  value: 0
foo:
  class: Foo
  args:
    debug:
      $ref: debug

Now if you use empty value (0, '', ...) you'll get an error:

Invalid config for service 'foo': Service configuration incomplete. Missing one of "class", "value", "config"

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.667% when pulling c19c3bd on al-tom-ru:allow-false-values into 847914f on preaction:master.

@preaction
Copy link
Owner

Thanks! I'll get this out right now!

@preaction preaction merged commit 3878bdd into preaction:master Jul 8, 2021
preaction added a commit that referenced this pull request Jul 8, 2021
@preaction
release v1.025
f6d255f 
    [Fixed]

    - Fixed using false/undef values as value services. Thanks
      @al-tom-ru for providing this patch! [Github #75]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@al-tom-ru @coveralls @preaction