Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixups #59

Merged
merged 42 commits into from
Apr 26, 2019
Merged

Fixups #59

merged 42 commits into from
Apr 26, 2019

Conversation

mohawk2
Copy link
Contributor

@mohawk2 mohawk2 commented Feb 17, 2019

These are further minor fixups on the path to having "relations" work.

This closes #48.

@coveralls
Copy link

coveralls commented Feb 17, 2019

Coverage Status

Coverage increased (+0.2%) to 99.541% when pulling 1fdf5ea on mohawk2:fixups into 9e7aece on preaction:master.

@mohawk2 mohawk2 force-pushed the fixups branch 2 times, most recently from 7f4f0dc to 486c729 Compare February 17, 2019 18:12
@mohawk2
Copy link
Contributor Author

mohawk2 commented Feb 17, 2019

Notable changes in the last few commits:

  • unify tests to all use %Yancy::Backend::Test::SCHEMA - rationale is that all the tests need to work with real backends, and this exposes any failure
  • now if there is a single unique column that is not a PK (which I gather is called a "natural" key, like an SSN), x-id-field will be set to that over a "surrogate" (normal relational ID) integer one

@mohawk2 mohawk2 force-pushed the fixups branch 2 times, most recently from ba9563d to d1c37a4 Compare February 23, 2019 08:59
@mohawk2
Copy link
Contributor Author

mohawk2 commented Feb 23, 2019

I've made the backend tests apply exactly the same tests to the mock one, which needed a bit of tweaking. I also added @rmallah's idea (in #49) of handling list for boolean in the backends, and adjusted his commit to then use that, which you can see is now included!

@mohawk2 mohawk2 force-pushed the fixups branch 3 times, most recently from cb6e718 to 153af48 Compare March 20, 2019 01:48
@mohawk2 mohawk2 force-pushed the fixups branch 2 times, most recently from 9d39a83 to a639ce3 Compare April 25, 2019 19:37
@preaction preaction merged commit 951860e into preaction:master Apr 26, 2019
@mohawk2 mohawk2 deleted the fixups branch April 26, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better handling of filters based on column type
4 participants