Merge da7e682 into 42aff16

preactjs · Aug 11, 2019 · 37ab127 · 37ab127
2 parents 42aff16 + da7e682
commit 37ab127
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/diff/props.js b/src/diff/props.js
@@ -31,7 +31,7 @@ function setStyle(style, key, value) {
 		style.setProperty(key, value);
 	}
 	else {
-		style[key] = typeof value==='number' && IS_NON_DIMENSIONAL.test(key)===false ? value+'px' : value;
+		style[key] = typeof value==='number' && IS_NON_DIMENSIONAL.test(key)===false ? value+'px' : value || null;
 	}
 }
 

diff --git a/test/browser/render.test.js b/test/browser/render.test.js
@@ -436,6 +436,14 @@ describe('render()', () => {
 			expect(scratch.firstChild.style.backgroundColor).to.equal('blue');
 		});
 
+		// Issue #1850
+		it('should remove empty styles', () => {
+			render(<div style={{ visibility: 'hidden' }} />, scratch);
+			expect(scratch.firstChild.style.visibility).to.equal('hidden');
+			render(<div style={{ visibility: undefined }} />, scratch);
+			expect(scratch.firstChild.style.visibility).to.equal('');
+		});
+
 		// Skip test if the currently running browser doesn't support CSS Custom Properties
 		if (window.CSS && CSS.supports('color', 'var(--fake-var)')) {
 			it('should support css custom properties', () => {