Merge pull request #2380 from 38elements/isPropagationStopped

Fix event.isPropagationStopped()
preactjs · Mar 1, 2020 · c8bfb3c · c8bfb3c
2 parents b565b5a + 3e7d5ab
commit c8bfb3c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/compat/src/render.js b/compat/src/render.js
@@ -52,7 +52,13 @@ options.event = e => {
 	if (oldEventHook) e = oldEventHook(e);
 	e.persist = () => {};
 	e.isDefaultPrevented = () => e.defaultPrevented;
-	e.isPropagationStopped = () => e.stopPropagation;
+	const normalStopPropagation = e.stopPropagation;
+	let stoppedPropagating = false;
+	e.stopPropagation = function() {
+		stoppedPropagating = true;
+		normalStopPropagation.call(this);
+	};
+	e.isPropagationStopped = () => stoppedPropagating;
 	return (e.nativeEvent = e);
 };
 

diff --git a/compat/test/browser/events.test.js b/compat/test/browser/events.test.js
@@ -45,6 +45,14 @@ describe('preact/compat events', () => {
 		expect(() => event.persist()).to.not.throw();
 		expect(() => event.isDefaultPrevented()).to.not.throw();
 		expect(() => event.isPropagationStopped()).to.not.throw();
+
+		expect(event.isDefaultPrevented()).to.be.false;
+		event.preventDefault();
+		expect(event.isDefaultPrevented()).to.be.true;
+
+		expect(event.isPropagationStopped()).to.be.false;
+		event.stopPropagation();
+		expect(event.isPropagationStopped()).to.be.true;
 	});
 
 	it('should normalize ondoubleclick event', () => {