Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify the behavior of props.children #1125

Merged
merged 3 commits into from
May 30, 2018
Merged

Specify the behavior of props.children #1125

merged 3 commits into from
May 30, 2018

Conversation

andrewiggins
Copy link
Member

Adds tests to demonstrate & validate expectations of the behavior of props.children with different types of children.

@andrewiggins andrewiggins changed the title Specify the behavior of props.children with various children Specify the behavior of props.children May 29, 2018
k1r0s
k1r0s approved these changes May 30, 2018
View reviewed changes
Copy link
Contributor

@k1r0s k1r0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM! thanks @andrewiggins for your neat contrib

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 67e9fb7 on andrewiggins:spec-props-children-type into 2399c49 on developit:master.

@k1r0s k1r0s merged commit 7f0ee26 into preactjs:master May 30, 2018
@andrewiggins andrewiggins deleted the spec-props-children-type branch May 30, 2018 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k1r0s k1r0s k1r0s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewiggins @coveralls @k1r0s