Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add types for <dialog>'s close & cancel events #4017

Merged
merged 2 commits into from
May 20, 2023
Merged

fix: Add types for <dialog>'s close & cancel events #4017

merged 2 commits into from
May 20, 2023

Conversation

rschristian
Copy link
Member

@rschristian rschristian commented May 19, 2023 •
edited
Loading

Closes #4013

Edit: I'll add that I did some testing and onCancel won't work in Firefox due to oncancel being undefined, rather than null, on Dialog elements. Fails the in dom check. Am working to get a fix upstream, but no bugs here. Both events work fine on Chrome.

@coveralls
Copy link

coveralls commented May 19, 2023 •
edited
Loading

Coverage Status

Coverage: 99.705%. Remained the same when pulling a25247b on types/dialog-events into 0b881e9 on master.

@rschristian rschristian merged commit c252e21 into master May 20, 2023
@rschristian rschristian deleted the types/dialog-events branch May 20, 2023 07:19
@JoviDeCroock JoviDeCroock mentioned this pull request May 20, 2023
Merged
JoviDeCroock added a commit that referenced this pull request Jan 24, 2024
@JoviDeCroock
backport #4017
6d9cd2a
JoviDeCroock added a commit that referenced this pull request Jan 24, 2024
@JoviDeCroock
Backport 10.15 release line (#4265)
255d011 
* backport #4016

* backport #3996

* backport #4017

* backport #4019

* backport #4020

* backport #4026

* backport #4028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cancel and close HTMLDialogElement events are not defined in tsx definitions
3 participants
@rschristian @coveralls @JoviDeCroock