Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[preact-iso] Fix Router un-rendering incoming same-component route #870

Merged
merged 3 commits into from
Sep 19, 2021
Merged

[preact-iso] Fix Router un-rendering incoming same-component route #870

merged 3 commits into from
Sep 19, 2021

Commits on Sep 17, 2021

  1. [preact-iso] Fix Router un-rendering incoming same-component route 

    I'm not 100% sure if this is the right solution, but reverting this line fixes the issue:
https://github.com/preactjs/wmr/pull/835/files#diff-b8c8c162d167c1ad31cb8461c49197c9c5527c58c2cde64d5c082d7359878ffdL123

My thinking is that `url` here is the full `location.path + location.search`, so the worst case is that we're potentially re-rendering routers that are unaffected by a given URL change.
    @developit
    developit committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    29a8880 View commit details
    Browse the repository at this point in the history

  2. Create rude-moons-grow.md

    @developit
    developit committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    69d291f View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2021

  1. Update .changeset/rude-moons-grow.md 

    Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
    @marvinhagemeister @JoviDeCroock
    marvinhagemeister and JoviDeCroock committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    3d3a392 View commit details
    Browse the repository at this point in the history