Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callback is not invoked when adUnits are undefined or empty #454

Closed
therazor opened this issue Jul 19, 2016 · 0 comments
Closed

Callback is not invoked when adUnits are undefined or empty #454

therazor opened this issue Jul 19, 2016 · 0 comments
Assignees
@protonate

Comments

@therazor
Copy link
Contributor

therazor commented Jul 19, 2016 •
edited
Loading

We have a variety of pages where some ad slots are served by DFP exclusively and some others use prebidding.
In some cases, there are no prebid slots at all, resulting in an empty pbjs.adUnits array.

It makes sense for pages without prebid ads to execute the callback straight away.

Relevant code is in the requestBids method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@protonate protonate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@therazor @protonate