Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underdogmedia Bid Adapter: Update pbTimeout Assignment #10466

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

kevpark02
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

  • Sometimes pbTimeout is passed as a string, causing unmarshal fail
  • Convert pbTimeout to a number, and if it is not a number (NaN), default to 3001ms

Other information

Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an associated unit test

@robertrmartinez robertrmartinez self-assigned this Oct 10, 2023
@kevpark02
Copy link
Contributor Author

@robertrmartinez thank you for catching it. I just added the unit tests required for the change!

Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thank you!

@robertrmartinez robertrmartinez merged commit e86dfcf into prebid:master Oct 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants