Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media.net adapter added #2038

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Conversation

vedantseta
Copy link
Contributor

@vedantseta vedantseta commented Jan 17, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

The PR adds Media.net adapter

  • test parameters for validating bids.
var adUnits = [{
          code: 'div-gpt-ad-1460505748561-0',
          sizes: [[300, 250], [300,600]],
  
          bids: [{
              bidder: 'medianet',
              params: {
                  cid : '8CUX0H51C',
                  site: {
                      page: 'http://smoketesting.net/prebidtest',
                      domain: 'smoketesting.net',
                      ref: 'http://smoketesting.net/prebidtest'
                  }
              }
          }]

     }];

PR on the docs repo at prebid/prebid.github.io#549

@vedantseta
Copy link
Contributor Author

@mkendall07 , Getting this error on Travis
Cannot start ChromeHeadless

Could you check ?
Thanks.

@mkendall07
Copy link
Member

the issue is on travis side. You'll need to rebase off master to get travis working again since I just merged a workaround

@matthewlane
Copy link
Collaborator

@vedantseta When testing this adapter with the provided bidder parameters, was getting a CORS error at first but that seems to have been resolved. However, am now getting back empty bids with no_bid: true status. Please check and advise how to test for valid bids and then I'll continue with the review, thanks

@ruturajv
Copy link

@matthewlane Thanks for taking a look at the adapter. A campaign needs to be active / setup for a bid to be returned. You can use the following for a successful bid.

      var adUnits = [{
        code: 'div-gpt-ad-1460505748561-0',
        sizes: [[300, 250], [300,600]],

        // Replace this object to test a new Adapter!
        bids: [{
          bidder: 'medianet',
            params: {
              cid: '8CUX0H51C',
              // Site member is to be used only for testing
              site: {
                  page: 'http://smoketesting.net/prebidtest/',
                  domain: 'smoketesting.net',
                  ref: 'http://smoketesting.net/prebidtest/'
              }
            }
        }]

      }];

I've been checking it on http://localhost:9999/integrationExamples/gpt/hello_world.html and I'm successfully getting bids.

Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Params are returning bids now, thanks. LGTM

@jaiminpanchal27 jaiminpanchal27 merged commit 1e8155b into prebid:master Jan 22, 2018
Millerrok pushed a commit to Vertamedia/Prebid.js that referenced this pull request Jan 23, 2018
* 'master' of https://github.com/prebid/Prebid.js: (23 commits)
  Update Atomx adapter for Prebid v1.0 (prebid#2026)
  Add vi bid adapter (prebid#2020)
  Add eplanningBidAdapter (prebid#2003)
  OpenX Adapter: Update to support mediaTypes field, instead of the deprecated mediaType field (prebid#1974)
  Separate bids & won calls (prebid#2015)
  1.0 adapter support for mantis (prebid#1840)
  Media.net adapter added (prebid#2038)
  GumGum Adapter for Prebid.js 1.0 (prebid#1966)
  Serverbid Bid Adapter: updated docs and ad sizes (prebid#2023)
  Adding districtm as an alias (prebid#2018)
  Use sudo to workaround Travis regression (prebid#2041)
  Fix uncached video bids triggering callback early (prebid#2017)
  Re-implemented RhythmOne audit beacon in prebid 1.0 interface (prebid#1953)
  Add NasmediaAdmixer adapter for Perbid.js 1.0 (prebid#1937)
  Update Adform adapter to Prebid v1.0 (prebid#1947)
  Upgrade Admixer adapter for Prebid 1.0 (prebid#1755)
  multiformat size validation checks (prebid#1964)
  Gjirafa Bidder Adapter (prebid#1944)
  pin gulp-connect at non-broken version (prebid#2008)
  Added dynamic ttl property for One Display and One Mobile. (prebid#2004)
  ...
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants