custom namespacing - use PrebidGlobal in the source code, replace it with pbjs as a webpack step

[baragona]

The name "PrebidGlobal" was chosen as it's less likely to cause conflicts. A webpack step will convert every instance of that string with "pbjs" -- configurable in package.json .

Why do this with webpack instead of a gulp task? Because when running the tests with karma, only webpack is applied, no other operations that gulp is configured to apply.

Currently the tests only pass if the global name is configured to be 'pbjs'. That's because I did not rename all usages of pbjs to PrebidGlobal in the tests (yet). See this in the karma conf:

    preprocessors: {
      'test/**/*_spec.js': ['webpack'],
      'src/**/*.js': ['webpack', 'coverage']
    },

Is that going to apply webpack to all the test files that may need substitution?

Hope this helps.

[baragona]

By the way I won't be able to collect any stats on whether this breaks anything until tomorrow.

[baragona]

update: I'm running this in production with a bunch of adapters and don't see any issues.

[mkendall07]

@ojotoxy
Thanks for the cleaned up PR. We are going to change the global name to something like $$PREBID_GLOBAL$$ which still is a valid identifier and also makes it more clear it will be string replaced.

[protonate]

I tried a quick replace of PrebidGlobal with $$PREBID_GLOBAL$$ and we will also need to replace the global var in test files and example files in ./integrationExamples/gpt/, so the StringReplacePlugin loader in webpack.conf needs to include "integrationExamples". Then if you would squash commits, we'll have another review and get this merged.

[nedstankus]

What's the plan for this feature? I'd love to see it in the next release and am able to help with the code if there's a need.

[protonate]

Thanks @nedstankus PRs are welcome. We stalled on this work and are at the point where the changes should be applied fresh to current master. The global var would need to be changed in all src and test files.

[mkendall07]

@ojotoxy
Closing out this PR since it's stale. Would still accept a new PR for this feature using $$PREBID_GLOBAL$$ as the param for pbjs replacement. Thanks

[nedstankus]

I've ported these changes to v0.9 and submitted a new PR:
#409