Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bidfloor parameter to AOL adapter #324

Merged
merged 2 commits into from
Apr 21, 2016
Merged

Conversation

kizzard
Copy link
Contributor

@kizzard kizzard commented Apr 19, 2016

We set the bidfloor parameter of the bid request object to a numeric string representing decimal CPM. If the bidfloor is not set, we pass the empty string which excludes the parameter from the resulting bid request call.

@kizzard
Copy link
Contributor Author

kizzard commented Apr 21, 2016

By the way - I work at AOL on the Header Bidding integration team - please reach out to me if you need to verify. Thanks!

@protonate protonate self-assigned this Apr 21, 2016
@mkendall07 mkendall07 assigned mkendall07 and unassigned protonate Apr 21, 2016
@mkendall07
Copy link
Member

Was able to get this to work, thanks. Can you please submit a PR for the docs as well?
https://raw.githubusercontent.com/prebid/prebid.github.io/master/dev-docs/bidders.md

@mkendall07 mkendall07 merged commit ad434a5 into prebid:master Apr 21, 2016
@kizzard
Copy link
Contributor Author

kizzard commented Apr 21, 2016

Will do!

@headerbidding
Copy link

Hi Jerremy,

How does the bidfloor set in the tag params relate to the bid floor set in the AOL control panel?

Do both work the same?

Does one override the other?

Hubert Heller

Flixxy.com

From: Jeremy Blencowe [mailto:notifications@github.com]
Sent: Wednesday, April 20, 2016 8:34 PM
To: prebid/Prebid.js
Cc: Flixxy; Manual
Subject: Re: [prebid/Prebid.js] Add bidfloor parameter to AOL adapter (#324)

By the way - I work at AOL on the Header Bidding integration team - please reach out to me if you need to verify. Thanks!


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub #324 (comment) Image removed by sender.

AOL

bidder code:

aol

bid params

Name

Scope

Description

Example

placement

required

The placement ID from AOL.

"23324932"

network

required

The network ID from AOL.

"5071.1"

alias

optional

The placement alias from AOL. Must be unique per page.

"desktop_articlepage_something_box_300_250"

server

optional

The server domain name. Default is adserver.adtechus.com. EU customers must use adserver.adtech.de.

"adserver.adtech.de"

sizeId

optional

The size ID from AOL.

"170"

bidfloor

optional

Dynamic bid floor

0.80

(The first of the sizes set in adUnit object will also apply to the AOL bid requests.)

@kizzard
Copy link
Contributor Author

kizzard commented Apr 26, 2016

Hi Hubert,

The dynamic bid floor will override the price floor configured in the UI if it is higher, but not if it is lower.

For example an 80c dynamic bid floor will override a 60c price floor in the rules, but a 60c dynamic bid floor will not override an 80c price floor set in the rules.

I hope that helps. If you need further clarification, feel free to reach out to me via email.

Jeremy

@headerbidding
Copy link

Thank you, Jeremy!

From: Jeremy Blencowe [mailto:notifications@github.com]
Sent: Tuesday, April 26, 2016 3:40 PM
To: prebid/Prebid.js
Cc: Flixxy; Manual
Subject: Re: [prebid/Prebid.js] Add bidfloor parameter to AOL adapter (#324)

Hi Hubert,

The dynamic bid floor will override the price floor configured in the UI if it is higher, but not if it is lower.

For example an 80c dynamic bid floor will override a 60c price floor in the rules, but a 60c dynamic bid floor will not override an 80c price floor set in the rules.

I hope that helps. If you need further clarification, feel free to reach out to me via email.

Jeremy


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub #324 (comment) Image removed by sender.

@kizzard
Copy link
Contributor Author

kizzard commented Apr 26, 2016

Hubert, I will email you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants