Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auction key limiter feature #3825

Merged
merged 4 commits into from
May 28, 2019
Merged

auction key limiter feature #3825

merged 4 commits into from
May 28, 2019

Conversation

jsnellbaker
Copy link
Collaborator

Type of change

  • Feature
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

PR for the feature described in: #3800

To enable the feature, add the following to code to the prebid config code on a test page:

pbjs.setConfig({
  targetingControls: {
    auctionKeyCharacterThreshold: 5000
  }
});

If you enable debug mode, you can watch the console logs for some details about which sets of keys are permitted/blocked.

In this initial submission, the prioritization of keys are based on the following factors:

  • bids with a deal are given preference over bids w/o a deal
  • bids with the higher CPM are given higher preference

Other information

Docs PR pending...

Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, I would like to change the param name to something like auctionKeyMaxChars to be more clear about what it does.

@jaiminpanchal27 jaiminpanchal27 merged commit e88dec1 into master May 28, 2019
kd-appier added a commit to appier/Prebid.js that referenced this pull request May 30, 2019
* 'master' of https://github.com/appier/Prebid.js: (160 commits)
  Increment pre version
  Prebid 2.17.0 Release
  mgid adapter: add support of currency.adServerCurrency (prebid#3850)
  We want to remove bidfloor if not set by pb (prebid#3866)
  aardvark tdid support (prebid#3860)
  auction key limiter feature (prebid#3825)
  minor updates to consentManagement tests (prebid#3849)
  Rhythmone Adapter - Multiple ad size support, rewrite tests, update docs. (prebid#3854)
  Adding bidfloor to video imp req (prebid#3863)
  adding Outstream mediaType to EMX Digital (prebid#3840)
  Added optional dealId parameter to bid response. (prebid#3858)
  Update rtbhouseBidAdapter.md (prebid#3857)
  Updated the bidder code in the test ad unit. (prebid#3844)
  change in Aardvark adapter to handle additional data  (prebid#3821)
  Refactor bid response - remove unnecessary properties (prebid#3807)
  Increment pre version
  Prebid 2.16.0 release
  fix how native sizes are passed in AppNexus adapter (prebid#3832)
  updated ozone adapter from v1.4.4 -> v2.0.0 (prebid#3828)
  Adding advertiserId to appnexus adapter (prebid#3833)
  ...
kd-appier added a commit to appier/Prebid.js that referenced this pull request May 30, 2019
* master: (160 commits)
  Increment pre version
  Prebid 2.17.0 Release
  mgid adapter: add support of currency.adServerCurrency (prebid#3850)
  We want to remove bidfloor if not set by pb (prebid#3866)
  aardvark tdid support (prebid#3860)
  auction key limiter feature (prebid#3825)
  minor updates to consentManagement tests (prebid#3849)
  Rhythmone Adapter - Multiple ad size support, rewrite tests, update docs. (prebid#3854)
  Adding bidfloor to video imp req (prebid#3863)
  adding Outstream mediaType to EMX Digital (prebid#3840)
  Added optional dealId parameter to bid response. (prebid#3858)
  Update rtbhouseBidAdapter.md (prebid#3857)
  Updated the bidder code in the test ad unit. (prebid#3844)
  change in Aardvark adapter to handle additional data  (prebid#3821)
  Refactor bid response - remove unnecessary properties (prebid#3807)
  Increment pre version
  Prebid 2.16.0 release
  fix how native sizes are passed in AppNexus adapter (prebid#3832)
  updated ozone adapter from v1.4.4 -> v2.0.0 (prebid#3828)
  Adding advertiserId to appnexus adapter (prebid#3833)
  ...
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* auction key limiter feature - initial commit

* Updated config name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants