Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantcast Adapter: Added optional dealId parameter to bid response. #3858

Merged
merged 1 commit into from
May 27, 2019

Conversation

dpapworth-qc
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Add support for dealId in bid response from Quantcast.

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@mike-chowla mike-chowla changed the title Added optional dealId parameter to bid response. Quantcast Adapter: Added optional dealId parameter to bid response. May 27, 2019
@mike-chowla mike-chowla self-requested a review May 27, 2019 16:47
@mike-chowla mike-chowla self-assigned this May 27, 2019
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit 3f1b739 into prebid:master May 27, 2019
kd-appier added a commit to appier/Prebid.js that referenced this pull request May 30, 2019
* 'master' of https://github.com/appier/Prebid.js: (160 commits)
  Increment pre version
  Prebid 2.17.0 Release
  mgid adapter: add support of currency.adServerCurrency (prebid#3850)
  We want to remove bidfloor if not set by pb (prebid#3866)
  aardvark tdid support (prebid#3860)
  auction key limiter feature (prebid#3825)
  minor updates to consentManagement tests (prebid#3849)
  Rhythmone Adapter - Multiple ad size support, rewrite tests, update docs. (prebid#3854)
  Adding bidfloor to video imp req (prebid#3863)
  adding Outstream mediaType to EMX Digital (prebid#3840)
  Added optional dealId parameter to bid response. (prebid#3858)
  Update rtbhouseBidAdapter.md (prebid#3857)
  Updated the bidder code in the test ad unit. (prebid#3844)
  change in Aardvark adapter to handle additional data  (prebid#3821)
  Refactor bid response - remove unnecessary properties (prebid#3807)
  Increment pre version
  Prebid 2.16.0 release
  fix how native sizes are passed in AppNexus adapter (prebid#3832)
  updated ozone adapter from v1.4.4 -> v2.0.0 (prebid#3828)
  Adding advertiserId to appnexus adapter (prebid#3833)
  ...
kd-appier added a commit to appier/Prebid.js that referenced this pull request May 30, 2019
* master: (160 commits)
  Increment pre version
  Prebid 2.17.0 Release
  mgid adapter: add support of currency.adServerCurrency (prebid#3850)
  We want to remove bidfloor if not set by pb (prebid#3866)
  aardvark tdid support (prebid#3860)
  auction key limiter feature (prebid#3825)
  minor updates to consentManagement tests (prebid#3849)
  Rhythmone Adapter - Multiple ad size support, rewrite tests, update docs. (prebid#3854)
  Adding bidfloor to video imp req (prebid#3863)
  adding Outstream mediaType to EMX Digital (prebid#3840)
  Added optional dealId parameter to bid response. (prebid#3858)
  Update rtbhouseBidAdapter.md (prebid#3857)
  Updated the bidder code in the test ad unit. (prebid#3844)
  change in Aardvark adapter to handle additional data  (prebid#3821)
  Refactor bid response - remove unnecessary properties (prebid#3807)
  Increment pre version
  Prebid 2.16.0 release
  fix how native sizes are passed in AppNexus adapter (prebid#3832)
  updated ozone adapter from v1.4.4 -> v2.0.0 (prebid#3828)
  Adding advertiserId to appnexus adapter (prebid#3833)
  ...
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants