Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding bidfloor to video imp req #3863

Merged
merged 1 commit into from
May 28, 2019
Merged

Adding bidfloor to video imp req #3863

merged 1 commit into from
May 28, 2019

Conversation

robertrmartinez
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

Rubicon param floor was not sent into RTB Video call correctly, should be passed inside req.imp.bidfloor.

@idettman idettman merged commit 445df80 into master May 28, 2019
kd-appier added a commit to appier/Prebid.js that referenced this pull request May 30, 2019
@kd-appier
Merge branch 'master' of https://github.com/appier/Prebid.js
d8a2159 
* 'master' of https://github.com/appier/Prebid.js: (160 commits)
  Increment pre version
  Prebid 2.17.0 Release
  mgid adapter: add support of currency.adServerCurrency (prebid#3850)
  We want to remove bidfloor if not set by pb (prebid#3866)
  aardvark tdid support (prebid#3860)
  auction key limiter feature (prebid#3825)
  minor updates to consentManagement tests (prebid#3849)
  Rhythmone Adapter - Multiple ad size support, rewrite tests, update docs. (prebid#3854)
  Adding bidfloor to video imp req (prebid#3863)
  adding Outstream mediaType to EMX Digital (prebid#3840)
  Added optional dealId parameter to bid response. (prebid#3858)
  Update rtbhouseBidAdapter.md (prebid#3857)
  Updated the bidder code in the test ad unit. (prebid#3844)
  change in Aardvark adapter to handle additional data  (prebid#3821)
  Refactor bid response - remove unnecessary properties (prebid#3807)
  Increment pre version
  Prebid 2.16.0 release
  fix how native sizes are passed in AppNexus adapter (prebid#3832)
  updated ozone adapter from v1.4.4 -> v2.0.0 (prebid#3828)
  Adding advertiserId to appnexus adapter (prebid#3833)
  ...
kd-appier added a commit to appier/Prebid.js that referenced this pull request May 30, 2019
@kd-appier
Merge branch 'master' into appier-analytics-release-1.0.0
8a115fc 
* master: (160 commits)
  Increment pre version
  Prebid 2.17.0 Release
  mgid adapter: add support of currency.adServerCurrency (prebid#3850)
  We want to remove bidfloor if not set by pb (prebid#3866)
  aardvark tdid support (prebid#3860)
  auction key limiter feature (prebid#3825)
  minor updates to consentManagement tests (prebid#3849)
  Rhythmone Adapter - Multiple ad size support, rewrite tests, update docs. (prebid#3854)
  Adding bidfloor to video imp req (prebid#3863)
  adding Outstream mediaType to EMX Digital (prebid#3840)
  Added optional dealId parameter to bid response. (prebid#3858)
  Update rtbhouseBidAdapter.md (prebid#3857)
  Updated the bidder code in the test ad unit. (prebid#3844)
  change in Aardvark adapter to handle additional data  (prebid#3821)
  Refactor bid response - remove unnecessary properties (prebid#3807)
  Increment pre version
  Prebid 2.16.0 release
  fix how native sizes are passed in AppNexus adapter (prebid#3832)
  updated ozone adapter from v1.4.4 -> v2.0.0 (prebid#3828)
  Adding advertiserId to appnexus adapter (prebid#3833)
  ...
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
@robertrmartinez
Adding bidfloor to video imp req (prebid#3863)
1f3e078
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 2, 2019
@robertrmartinez
Adding bidfloor to video imp req (prebid#3863)
b09a34a
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 2, 2019
@robertrmartinez
Adding bidfloor to video imp req (prebid#3863)
69724a8
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 2, 2019
@robertrmartinez
Adding bidfloor to video imp req (prebid#3863)
b90e7c1
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 2, 2019
@robertrmartinez
Adding bidfloor to video imp req (prebid#3863)
48c7583
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 2, 2019
@robertrmartinez
Adding bidfloor to video imp req (prebid#3863)
c7db86b
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 2, 2019
@robertrmartinez
Adding bidfloor to video imp req (prebid#3863)
cf01789
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 2, 2019
@robertrmartinez
Adding bidfloor to video imp req (prebid#3863)
1f21ca9
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 2, 2019
@robertrmartinez
Adding bidfloor to video imp req (prebid#3863)
85a3c07
@robertrmartinez robertrmartinez deleted the fix_rubicon_bid_floor branch September 21, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idettman idettman idettman approved these changes

@bretg bretg bretg approved these changes

@harpere harpere Awaiting requested review from harpere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robertrmartinez @idettman @bretg