Teads-Adapter: Update way to find referrer #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
approved these changes
May 15, 2019
There was a problem hiding this comment.
Hi @valsouche
The code changes look to be fine. I checked your unit tests though and didn't see any that include the referrer param. Did you want to take the opportunity to setup/alter one of the tests to cover this gap?
Please confirm either way when you have the chance.
|
Hello @jsnellbaker, |
|
Hi @valsouche, Thanks for making the update. Though it seems that |
|
@valsouche Thanks for the update; LGTM |
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* Update way to find referrer * Add test * Delete npm-debug.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Update the deprecated method to get the referrer. Now using referrerInfo object.