Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if schain config is not defined then error should not be thrown #4165

Merged
merged 5 commits into from
Sep 13, 2019
Merged

if schain config is not defined then error should not be thrown #4165

merged 5 commits into from
Sep 13, 2019

Conversation

pm-harshad-mane
Copy link
Contributor

Type of change

  • Bugfix

Description of change

if schain config is not defined then the error should not be thrown

@pm-harshad-mane
Copy link
Contributor Author

Hello @bretg ,

@mike-chowla asked me to handle this case, can you please review the change?

@bretg bretg added the needs 2nd review Core module updates require two approvals from the core team label Sep 8, 2019
@pm-harshad-mane
Copy link
Contributor Author

Hello @jaiminpanchal27 ,
Can you please review this PR as well?

jaiminpanchal27
jaiminpanchal27 reviewed Sep 9, 2019
View reviewed changes
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is lgtm. Can you add unit tests ?

@pm-harshad-mane
Copy link
Contributor Author

Hello @jaiminpanchal27 ,
Sorry for the delay.
I have added unit-test cases now, also fixed one more issue and the documentation.

@jaiminpanchal27 jaiminpanchal27 added LGTM and removed needs 2nd review Core module updates require two approvals from the core team labels Sep 13, 2019
@jaiminpanchal27 jaiminpanchal27 merged commit 3915517 into prebid:master Sep 13, 2019
@pm-harshad-mane
Copy link
Contributor Author

Thank you @jaiminpanchal27

@pm-manasi-moghe pm-manasi-moghe mentioned this pull request Jan 13, 2021
Merged
10 tasks
@pm-manasi-moghe pm-manasi-moghe mentioned this pull request Jan 25, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

Assignees

@jaiminpanchal27 jaiminpanchal27

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pm-harshad-mane @bretg @jaiminpanchal27