Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubiconAnalyticsAdapter.js with gvlid #5681

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Update rubiconAnalyticsAdapter.js with gvlid #5681

merged 2 commits into from
Aug 31, 2020

Conversation

patmmccann
Copy link
Collaborator

@patmmccann patmmccann commented Aug 31, 2020

This adds the gvl id as per https://github.com/prebid/Prebid.js/pull/5444/files

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

@patmmccann
Copy link
Collaborator Author

fyi @robertrmartinez

@robertrmartinez
Copy link
Collaborator

Thanks @patmmccann

I have a feature I am working on which I included this change in already. PR is going to be made today or tomorrow.

But no hurt in merging this just in case my stuff does not get into this weeks release!

@robertrmartinez robertrmartinez merged commit a2f2ac6 into prebid:master Aug 31, 2020
@patmmccann patmmccann deleted the patch-31 branch August 31, 2020 16:48
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
* Update rubiconAnalyticsAdapter.js

This adds the gvl id as per https://github.com/prebid/Prebid.js/pull/5444/files

* Update rubiconAnalyticsAdapter.js
BrightMountainMediaInc added a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants