-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetIntent adapter + tests (slightly compressed) #579
Conversation
floor: bidRequest.params.floor, // optional | ||
known: bidRequest.params.known || 1, // optional | ||
size: bidRequest.sizes[0].join("x"), | ||
}, function(bidResponse) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use /*jshint loopfunc: true */
to silence the jshint error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@mkendall07 can we get a rough estimation when this will be merged and go to the next release? |
@dmart28 |
@mkendall07 Yes, this is official submission. |
@dmart28 Are the test params still valid? I'm not getting bids back with them |
@matthewlane thanks for the hint, we had actually done some changes, so I reflected them to the adapter. For the given parameters it returned now the ad, please check it again. |
Great, getting bids back now. Thanks for the adapter and test coverage! |
* GetIntent adapter + tests (slightly compressed) * fixy. * rollback and silence JSHint. * fix adapter.
* GetIntent adapter + tests (slightly compressed) * fixy. * rollback and silence JSHint. * fix adapter.
Contact: server-dev@getintent.com
Test params:
pid: '7',
tid: 'prebid_test',
size: [[240,400]]