GetIntent adapter + tests (slightly compressed) #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| floor: bidRequest.params.floor, // optional | ||
| known: bidRequest.params.known || 1, // optional | ||
| size: bidRequest.sizes[0].join("x"), | ||
| }, function(bidResponse) { |
There was a problem hiding this comment.
You can use /*jshint loopfunc: true */ to silence the jshint error.
|
@mkendall07 can we get a rough estimation when this will be merged and go to the next release? |
|
@dmart28 |
|
@mkendall07 Yes, this is official submission. |
|
@dmart28 Are the test params still valid? I'm not getting bids back with them |
|
@matthewlane thanks for the hint, we had actually done some changes, so I reflected them to the adapter. For the given parameters it returned now the ad, please check it again. |
|
Great, getting bids back now. Thanks for the adapter and test coverage! |
Studnicky
pushed a commit
to sonobi/Prebid.js
that referenced
this pull request
Oct 4, 2016
* GetIntent adapter + tests (slightly compressed) * fixy. * rollback and silence JSHint. * fix adapter.
Studnicky
pushed a commit
to sonobi/Prebid.js
that referenced
this pull request
Oct 4, 2016
* GetIntent adapter + tests (slightly compressed) * fixy. * rollback and silence JSHint. * fix adapter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contact: server-dev@getintent.com
Test params:
pid: '7',
tid: 'prebid_test',
size: [[240,400]]