-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional sizes to rubicon size mapping #646
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the following sizes to rubicon size map * '640x480':65 * '800x250':125 * '200x600':126
bretg
approved these changes
Sep 21, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the sizes and code changes.
Please note that adding sizes in the adapter may not be enough to initiate auctions for those sizes. Please work with your Rubicon Project account rep to enable them on the backend. |
Studnicky
pushed a commit
to sonobi/Prebid.js
that referenced
this pull request
Oct 4, 2016
* Add new rubicon sizes This commit adds the following sizes to rubicon size map * '640x480':65 * '800x250':125 * '200x600':126 * codestyle rubicon sizemap
marian-r
pushed a commit
to aol/Prebid.js
that referenced
this pull request
Nov 2, 2016
…ebid-0.13.1 to release/1.4.0 * commit 'd174ef271e55e7f26210f50caac52c0a036bc9a1': CHANGELOG. 0.13.1 release add an --https flag to run local dev server over https (prebid#670) test ie variant of url parse pathname (prebid#669) Prevent SpringServe TypeError (prebid#663) XDomainRequest does not support `readyState` and was not executing the callback. (prebid#668) Prevent Sovrn TypeError (prebid#664) Prevent TripleLift TypeError (prebid#662) fixed bug with using non standard "standard" keys and sendAllBids (prebid#665) Initial value 0 for adder. (prebid#656) Prevent bidmanager TypeError (prebid#661) Prevent Pubmatic TypeError (prebid#666) Size mapping functionality (prebid#651) Added '320x80': 59, '320x320': 72, '320x160': 73 to RUBICON_SIZE_MAP (prebid#649) Add defy alias + increment version. (prebid#650) Add additional sizes to rubicon size mapping (prebid#646)
marian-r
added a commit
to aol/Prebid.js
that referenced
this pull request
Nov 2, 2016
…4.0 to master * commit '5e7eec42d84ec5de47a28ba493a9357b595761d3': CHANGELOG. New adapter. 0.13.1 release add an --https flag to run local dev server over https (prebid#670) test ie variant of url parse pathname (prebid#669) Prevent SpringServe TypeError (prebid#663) XDomainRequest does not support `readyState` and was not executing the callback. (prebid#668) Prevent Sovrn TypeError (prebid#664) Prevent TripleLift TypeError (prebid#662) fixed bug with using non standard "standard" keys and sendAllBids (prebid#665) Initial value 0 for adder. (prebid#656) Prevent bidmanager TypeError (prebid#661) Prevent Pubmatic TypeError (prebid#666) Size mapping functionality (prebid#651) Added '320x80': 59, '320x320': 72, '320x160': 73 to RUBICON_SIZE_MAP (prebid#649) Add defy alias + increment version. (prebid#650) Add additional sizes to rubicon size mapping (prebid#646)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This commit adds the following sizes to rubicon size map