Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional sizes to rubicon size mapping #646

Merged
merged 2 commits into from
Sep 21, 2016
Merged

Add additional sizes to rubicon size mapping #646

merged 2 commits into from
Sep 21, 2016

Conversation

mlommatzsch
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

This commit adds the following sizes to rubicon size map

  • '640x480':65
  • '800x250':125
  • '200x600':126

Michael Lommatzsch added 2 commits September 21, 2016 11:48
This commit adds the following  sizes to rubicon size map

* '640x480':65
* '800x250':125
* '200x600':126
Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the sizes and code changes.

@mkendall07 mkendall07 merged commit 6022bf4 into prebid:master Sep 21, 2016
@mlommatzsch mlommatzsch deleted the rubicon_size_mapping branch September 22, 2016 07:11
@bretg
Copy link
Collaborator

bretg commented Sep 22, 2016

Please note that adding sizes in the adapter may not be enough to initiate auctions for those sizes. Please work with your Rubicon Project account rep to enable them on the backend.

Studnicky pushed a commit to sonobi/Prebid.js that referenced this pull request Oct 4, 2016
* Add new rubicon sizes

This commit adds the following  sizes to rubicon size map

* '640x480':65
* '800x250':125
* '200x600':126

* codestyle rubicon sizemap
marian-r pushed a commit to aol/Prebid.js that referenced this pull request Nov 2, 2016
…ebid-0.13.1 to release/1.4.0

* commit 'd174ef271e55e7f26210f50caac52c0a036bc9a1':
  CHANGELOG.
  0.13.1 release
  add an --https flag to run local dev server over https (prebid#670)
  test ie variant of url parse pathname (prebid#669)
  Prevent SpringServe TypeError (prebid#663)
  XDomainRequest does not support `readyState` and was not executing the callback. (prebid#668)
  Prevent Sovrn TypeError (prebid#664)
  Prevent TripleLift TypeError (prebid#662)
  fixed bug with using non standard "standard" keys and sendAllBids (prebid#665)
  Initial value 0 for adder. (prebid#656)
  Prevent bidmanager TypeError (prebid#661)
  Prevent Pubmatic TypeError (prebid#666)
  Size mapping functionality (prebid#651)
  Added '320x80': 59, '320x320': 72, '320x160': 73 to RUBICON_SIZE_MAP (prebid#649)
  Add defy alias + increment version. (prebid#650)
  Add additional sizes to rubicon size mapping (prebid#646)
marian-r added a commit to aol/Prebid.js that referenced this pull request Nov 2, 2016
…4.0 to master

* commit '5e7eec42d84ec5de47a28ba493a9357b595761d3':
  CHANGELOG.
  New adapter.
  0.13.1 release
  add an --https flag to run local dev server over https (prebid#670)
  test ie variant of url parse pathname (prebid#669)
  Prevent SpringServe TypeError (prebid#663)
  XDomainRequest does not support `readyState` and was not executing the callback. (prebid#668)
  Prevent Sovrn TypeError (prebid#664)
  Prevent TripleLift TypeError (prebid#662)
  fixed bug with using non standard "standard" keys and sendAllBids (prebid#665)
  Initial value 0 for adder. (prebid#656)
  Prevent bidmanager TypeError (prebid#661)
  Prevent Pubmatic TypeError (prebid#666)
  Size mapping functionality (prebid#651)
  Added '320x80': 59, '320x320': 72, '320x160': 73 to RUBICON_SIZE_MAP (prebid#649)
  Add defy alias + increment version. (prebid#650)
  Add additional sizes to rubicon size mapping (prebid#646)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants