First PR for initial development #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camrice
reviewed
Nov 7, 2022
parse_test.go
Outdated
| SectionStrings: []string{"DBABMA", "CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA"}, | ||
| Sectiontypes: []constants.SectionID{3, 2}, | ||
| Version: 1, | ||
| // SectionStrings: []string{"DBABMA", "CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA"}, |
There was a problem hiding this comment.
Is the SectionStrings here no longer needed?
There was a problem hiding this comment.
Already removed, just need to push. :)
parse.go
Outdated
| decoded = decoded[:n:n] | ||
|
|
||
| bs := util.NewBitStream(decoded) | ||
| if bs.Len() < 3 { |
There was a problem hiding this comment.
Can the check here use a constant in place of the 3?
| } | ||
| bs.SetPosition(6) |
There was a problem hiding this comment.
Can the SetPosition either use a constant or maybe just a comment to explain the position change?
There was a problem hiding this comment.
Not a bad idea to add a comment.
constants/constants.go
Outdated
| @@ -12,3 +12,5 @@ const ( | |||
| SectionUSPUT SectionID = 11 | |||
| SectionUSPCT SectionID = 12 | |||
| ) | |||
|
|
|||
| const SectionGPPByte byte = 'D' | |||
There was a problem hiding this comment.
Not sure if here or where it's used is better, but could you add a comment explaining how this is used?
There was a problem hiding this comment.
I moved this and added comments.
camrice
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.