Pbm native #247
Pbm native #247
Conversation
ppuviarasu
requested review from
yoalex5
and removed request for
akashVermaCardinal
* Added Unittest cases for PBM Native * Test cases updated
|
As I see you use |
|
#255 fixes modularisation issue |
| public var ext: AnyObject? | ||
|
|
||
| public required init(minimumWidth: Int, minimumHeight: Int, required: Bool) { | ||
| super.init(isRequired: required) |
There was a problem hiding this comment.
What if the publisher wants just exact width and height, but not mW and mH?
Can you provide an alternative Init method?
| @objc public enum ImageAsset: Int { | ||
| case Icon = 1 | ||
| case Main = 3 | ||
| case Custom = 500 |
There was a problem hiding this comment.
This Custom can not be changed?
| public var length: Int? | ||
| public var ext: AnyObject? | ||
|
|
||
| public required init(type: Int, required: Bool) { |
There was a problem hiding this comment.
Data has 12 fixed types and one custom type. Should not be using Int.
|
Hi @yoalex5,
Source code is in PUC, please check the latest release: https://github.com/prebid/prebid-universal-creative/releases |
ppuviarasu
dismissed
yoalex5’s stale review
Wei will complete the review for release
Implementation of PrebidNative for bannerNative DFP & mopub.
This is a banner native implementation as the creative is rendered as a universal creative served on a webview