Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process Stored Request/Imp IDs unique per account #488

Merged
merged 26 commits into from
Oct 27, 2020

Conversation

rpanchyk
Copy link
Contributor

@rpanchyk rpanchyk commented Oct 9, 2019

This PR covers prebid/prebid-server#1024 issue.

@rpanchyk rpanchyk requested review from schernysh and RossGoncharuk and removed request for schernysh October 9, 2019 10:52
RossGoncharuk
RossGoncharuk previously approved these changes Oct 9, 2019
Copy link
Contributor

@RossGoncharuk RossGoncharuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few Minor description corrections, other than that - all good!

docs/developers/stored-requests.md Outdated Show resolved Hide resolved
# Conflicts:
#	src/main/java/org/prebid/server/settings/FileApplicationSettings.java
rpanchyk added 11 commits December 13, 2019 14:27
# Conflicts:
#	src/main/java/org/prebid/server/settings/ApplicationSettings.java
#	src/main/java/org/prebid/server/settings/FileApplicationSettings.java
#	src/main/java/org/prebid/server/settings/JdbcApplicationSettings.java
#	src/test/java/org/prebid/server/auction/StoredRequestProcessorTest.java
# Conflicts:
#	src/main/java/org/prebid/server/auction/BidResponseCreator.java
#	src/test/java/org/prebid/server/auction/AuctionRequestFactoryTest.java
#	src/test/java/org/prebid/server/auction/StoredRequestProcessorTest.java
#	src/test/java/org/prebid/server/settings/JdbcApplicationSettingsTest.java
# Conflicts:
#	src/test/java/org/prebid/server/settings/JdbcApplicationSettingsTest.java
@rpanchyk rpanchyk marked this pull request as draft July 1, 2020 08:25
rpanchyk added 3 commits July 1, 2020 20:25
# Conflicts:
#	src/test/java/org/prebid/server/auction/StoredRequestProcessorTest.java
# Conflicts:
#	src/main/java/org/prebid/server/auction/AmpRequestFactory.java
#	src/main/java/org/prebid/server/auction/BidResponseCreator.java
@rpanchyk rpanchyk marked this pull request as ready for review July 2, 2020 16:24
@rpanchyk rpanchyk requested a review from schernysh July 2, 2020 16:24
schernysh
schernysh previously approved these changes Jul 16, 2020
# Conflicts:
#	docs/developers/stored-requests.md
#	src/test/java/org/prebid/server/settings/JdbcApplicationSettingsTest.java
rpanchyk added 5 commits September 3, 2020 16:32
# Conflicts:
#	src/main/java/org/prebid/server/auction/BidResponseCreator.java
#	src/test/java/org/prebid/server/settings/JdbcApplicationSettingsTest.java
# Conflicts:
#	src/main/java/org/prebid/server/auction/BidResponseCreator.java
#	src/main/java/org/prebid/server/auction/VideoRequestFactory.java
#	src/main/java/org/prebid/server/settings/HttpApplicationSettings.java
#	src/main/java/org/prebid/server/settings/model/TriFunction.java
@rpanchyk rpanchyk requested review from schernysh and removed request for RossGoncharuk October 27, 2020 10:22
@rpanchyk rpanchyk merged commit 814c742 into master Oct 27, 2020
@rpanchyk rpanchyk deleted the SRIDs-unique-per-account branch October 27, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants